Add internalapi routes for scenario A adoption #995
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: averdagu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
averdagu
requested review from
karelyatin
and removed request for
viroel and
fao89
| @@ -122,6 +122,18 @@ if [ -n "$IPV4_ENABLED" ]; then | |||
| "range_start": "${INTERNALAPI_PREFIX}.30", | |||
| "range_end": "${INTERNALAPI_PREFIX}.70" | |||
| EOF_CAT | |||
| # In the data-plane adoption scenario A (where different IP subnet ranges | |||
| # between next-gen and wallaby are used) the net-attach-def needs additional routes. | |||
There was a problem hiding this comment.
we should allow generic routes to be specified set with parameters, by default non will be set and by exporting env vars those could be set.
There was a problem hiding this comment.
Good idea, implementing it now
There was a problem hiding this comment.
wanted to have this generic for all the networks not just internalapi
Also can't we reuse other existing vars *_HOST_ROUTES instead of creating similar var?
averdagu
force-pushed
the
feat/scenario-a-routes
branch
from
de45bd5 to
21a840e
Compare
Doing data-plane adoption while testing scenario A (different subnets between wallaby and next-gen) will result in connectivity problem since pods will try to reach old CP using default route (since both CP are on different subnets) and won't be able to reach it. Adding this route in internalapi to support data-plane adoption scenario A gates. Currently only one route can be added, if needed logic can be improved to include more than one route. Ref: OSPRH-5602
averdagu
force-pushed
the
feat/scenario-a-routes
branch
from
21a840e to
bbf87f3
Compare
Doing data-plane adoption while testing scenario A (different subnets between wallaby and next-gen) will result in connectivity problem since pods will try to reach old CP using default route (since both CP are on different subnets) and won't be able to reach it.
Adding this route in internalapi to support data-plane adoption scenario A gates.