Ensure the openstacks crd exists in kuttl tests #998
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just checking for any openstack.org crd, check explicitely for openstacks.operator.openstack.org, and wait until that is available. In some CI jobs, we run kuttl test for other operators before the openstack-operators one. That means that the current check interprets the fact that there are some openstack crds as being ready. Then when it tries to get openstacks.operator.openstack.org, it fails because it's not present yet. Also remove the '|| true' at the end of the command, since that ignores any error that might occurr.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abays
reviewed
Jan 20, 2025
| @@ -2032,8 +2032,8 @@ openstack_kuttl_run: ## runs kuttl tests for the openstack operator, assumes tha | |||
| openstack_kuttl: export NAMESPACE = ${OPENSTACK_KUTTL_NAMESPACE} | |||
| openstack_kuttl: input deploy_cleanup openstack openstack_deploy_prep ## runs kuttl tests for the openstack operator. Installs openstack operator and cleans up previous deployments before running the tests, cleans up after running the tests. | |||
| # Wait until OLM installs openstack CRDs | |||
| timeout $(TIMEOUT) bash -c "while ! (oc get crd | grep openstack.org); do sleep 1; done" | |||
| bash -c '(oc get crd openstacks.operator.openstack.org && make openstack_init) || true' | |||
There was a problem hiding this comment.
I agree with removing this || true. We have seen it mask errors in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just checking for any openstack.org crd, check explicitely
for openstacks.operator.openstack.org, and wait until that is available.
In some CI jobs, we run kuttl test for other operators before the
openstack-operators one. That means that the current check interprets
the fact that there are some openstack crds as being ready. Then when it
tries to get openstacks.operator.openstack.org, it fails because it's
not present yet.
Also remove the '|| true' at the end of the command, since that ignores
any error that might occurr.