Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required infra annotations for OCP 4.14+ #355

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Nov 3, 2023

Update to use new 'features.operators.openshift.io' annotations format for disconnected support

Jira: OSP-30201

Update to use new 'features.operators.openshift.io' annotations format for disconnected support

Jira: OSP-30201
@juliakreger
Copy link
Contributor

/approve

@hjensas
Copy link
Contributor

hjensas commented Nov 5, 2023

/retest

Response - Headers: {'date': 'Fri, 03 Nov 2023 15:02:28 GMT', 'server': 'Apache', 'content-length': '2971', 'x-openstack-ironic-api-minimum-version': '1.1', 'x-openstack-ironic-api-maximum-version': '1.82', 'x-openstack-ironic-api-version': '1.1', 'openstack-request-id': 'req-a399a922-79d5-4a8b-b47b-ed8f6e278750', 'content-type': 'application/json', 'set-cookie': '0dca7ebaabe70eef509e843674c09f5f=15e20ce0d0459145a4bab71a751878b9; path=/; HttpOnly; Secure; SameSite=None', 'cache-control': 'private', 'connection': 'close', 'status': '200', 'content-location': 'https://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports'}
    Body: b'{"ports": [{"uuid": "89052c75-2d67-4bdb-8994-62f313195061", "address": "fa:16:3e:35:af:fd", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/89052c75-2d67-4bdb-8994-62f313195061", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/89052c75-2d67-4bdb-8994-62f313195061", "rel": "bookmark"}]}, {"uuid": "7345af3c-adad-4368-b9fa-8f0220e5d69f", "address": "fa:16:3e:46:73:0f", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/7345af3c-adad-4368-b9fa-8f0220e5d69f", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/7345af3c-adad-4368-b9fa-8f0220e5d69f", "rel": "bookmark"}]}, {"uuid": "a615e5fa-5b7b-423a-8735-3e54c3852455", "address": "fa:16:3e:4b:18:79", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci
.ccitredhat.com/v1/ports/a615e5fa-5b7b-423a-8735-3e54c3852455", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/a615e5fa-5b7b-423a-8735-3e54c3852455", "rel": "bookmark"}]}, {"uuid": "820c0333-8e7d-4b5f-b33d-1d7565a6d58e", "address": "fa:16:3e:90:ef:cb", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/820c0333-8e7d-4b5f-b33d-1d7565a6d58e", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/820c0333-8e7d-4b5f-b33d-1d7565a6d58e", "rel": "bookmark"}]}, {"uuid": "ee3de2c5-f3dd-4a3a-9341-36010969982b", "address": "fa:16:3e:91:0e:05", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/ee3de2c5-f3dd-4a3a-9341-36010969982b", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/ee3de2c5-f3dd-4a3a-9341-36010969982b", "rel": "bookmark"}]}, {"uuid": "74afcf34-f7be-4499-82b3-bf6242e4b73b", "address": "fa:16:3e:13:1a:dc", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/74afcf34-f7be-4499-82b3-bf6242e4b73b", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/74afcf34-f7be-4499-82b3-bf6242e4b73b", "rel": "bookmark"}]}, {"uuid": "f030ffd6-fdf5-47da-865f-3963349756a1", "address": "fa:16:3e:d1:e9:bb", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/f030ffd6-fdf5-47da-865f-3963349756a1", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/f030ffd6-fdf5-47da-865f-3963349756a1", "rel": "bookmark"}]}, {"uuid": "c2022f1c-0a40-46fb-8398-a84f292f7e0b", "address": "fa:16:3e:8b:87:71", "links": [{"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/c2022f1c-0a40-46fb-8398-a84f292f7e0b", "rel": "self"}, {"href": "http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/ports/c2022f1c-0a40-46fb-8398-a84f292f7e0b", "rel": "bookmark"}]}]}'

{3} ironic_tempest_plugin.tests.api.admin.test_ports.TestPorts.test_list_ports_details [1.760523s] ... FAILED

Captured traceback:

    Traceback (most recent call last):

      File "/usr/lib/python3.9/site-packages/ironic_tempest_plugin/tests/api/admin/test_ports.py", line 138, in test_list_ports_details
    self.validate_self_link('ports', port['uuid'],

      File "/usr/lib/python3.9/site-packages/ironic_tempest_plugin/tests/api/base.py", line 472, in validate_self_link
    self.assertEqual(expected_link, link)

      File "/usr/lib/python3.9/site-packages/testtools/testcase.py", line 393, in assertEqual
    self.assertThat(observed, matcher, message)

      File "/usr/lib/python3.9/site-packages/testtools/testcase.py", line 480, in assertThat
    raise mismatch_error

    testtools.matchers._impl.MismatchError: !=:
reference = 'https://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/d4d171ed-0a8f-487e-8224-6df4b6ee4414'
actual    = 'http://ironic-public-openstack.apps.oko-18.oooci.ccitredhat.com/v1/ports/d4d171ed-0a8f-487e-8224-6df4b6ee4414'

@dprince
Copy link
Contributor Author

dprince commented Nov 5, 2023

/test ironic-operator-build-deploy-tempest

1 similar comment
@dprince
Copy link
Contributor Author

dprince commented Nov 8, 2023

/test ironic-operator-build-deploy-tempest

@juliakreger
Copy link
Contributor

/retest

Copy link
Contributor

@juliakreger juliakreger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, juliakreger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprince,juliakreger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 041f394 into openstack-k8s-operators:main Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants