Merge pull request #376 from stuggi/no_commonName

[TLS] Don't set commonName and only use subjectAltNames
openstack-k8s-operators · Oct 23, 2023 · 357f2fa · 357f2fa
2 parents e9c65d1 + 0ef7e5f
commit 357f2fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/modules/certmanager/certificate.go b/modules/certmanager/certificate.go
@@ -57,9 +57,7 @@ func NewCertificate(
 // minimal spec should be:
 // Spec:
 //
-//	commonName: keystone-public-openstack.apps-crc.testing
 //	dnsNames:
-//	- keystone-public-openstack
 //	- keystone-public-openstack.apps-crc.testing
 //	issuerRef:
 //	   kind: Issuer
@@ -166,8 +164,7 @@ func EnsureCert(
 		namespace,
 		labels,
 		certmgrv1.CertificateSpec{
-			CommonName: hostnames[0],
-			DNSNames:   hostnames,
+			DNSNames: hostnames,
 			Duration: &metav1.Duration{
 				Duration: *duration,
 			},

diff --git a/modules/certmanager/issuer.go b/modules/certmanager/issuer.go
@@ -127,7 +127,7 @@ func (i *Issuer) CreateOrPatch(
 		return ctrl.Result{}, err
 	}
 	if op != controllerutil.OperationResultNone {
-		h.GetLogger().Info(fmt.Sprintf("Route %s - %s", issuer.Name, op))
+		h.GetLogger().Info(fmt.Sprintf("Issuer %s - %s", issuer.Name, op))
 	}
 
 	return ctrl.Result{}, nil