Add TLSInputReadyCondition #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuggi
reviewed
Oct 26, 2023
There was a problem hiding this comment.
do we also want to add specific TLS messages or reuse https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/condition/conditions.go#L126 ? maybe we add custom, especially for the error case ?
Deydra71
force-pushed
the
tls-condition
branch
from
c87ac8c to
ba187a0
Compare
gibizer
reviewed
Oct 26, 2023
| @@ -292,6 +295,9 @@ const ( | |||
|
|
|||
| // AnsibleEEReadyErrorMessage | |||
| AnsibleEEReadyErrorMessage = "AnsibleEE error occurred %s" | |||
|
|
|||
| // TLSInputErrorMessage - Provides the message when there's error in provision of TLS sources | |||
| TLSInputErrorMessage = "TLSInput error occured in TLS sources" | |||
There was a problem hiding this comment.
would be super useful to include some information about the specific error like in case of the AnsibleEEReadyErrorMessage above.
Indicating the condition when required TLS sources are ready or error occured. Signed-off-by: Veronika Fisarova <[email protected]>
Deydra71
force-pushed
the
tls-condition
branch
from
ba187a0 to
8bbfc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicating the condition when required TLS sources are ready.