Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate OLM cleanup for running local operator w/ webhooks #351

Merged

Conversation

abays
Copy link
Contributor

@abays abays commented Oct 16, 2024

When using make run-with-webhook, local versions of the operator and its webhooks are added to the cluster. If the operator was previously installed via OLM, then there might be lingering webhooks from that installation. We've previously been assuming that the user would manually remove them, but we should just get rid of them ourselves since those OLM webhooks need to be deleted anyhow for the local webhooks to function unimpeded. We can also automatically scale down the operator's OLM deployment in such a scenario.

@abays abays requested a review from fmount October 16, 2024 16:12
@openshift-ci openshift-ci bot requested a review from frenzyfriday October 16, 2024 16:13
Copy link
Collaborator

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays
Copy link
Contributor Author

abays commented Oct 16, 2024

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/manila-operator-build-deploy-tempest dffba43 link true /test manila-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

error: build error: Failed to push image: trying to reuse blob sha256:4d5d1cbd7ece41ce278c26338e01e2b82e1861b820ca052da9f3e0b16815358f at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": dial tcp 38.129.56.158:443: i/o timeout

/test manila-operator-build-deploy-tempest

@abays
Copy link
Contributor Author

abays commented Oct 16, 2024

/test manila-operator-build-deploy-kuttl

1 similar comment
@fmount
Copy link
Collaborator

fmount commented Oct 16, 2024

/test manila-operator-build-deploy-kuttl

@abays
Copy link
Contributor Author

abays commented Oct 16, 2024

@abays: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/manila-operator-build-deploy-kuttl dffba43 link true /test manila-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

error: unable to upgrade connection: container container-00 not found in pod oko-07-fddc9-master-1-debug-bdqz9_openstack
make: *** [Makefile:572: crc_storage] Error 1

/test manila-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot bot merged commit f06ae48 into openstack-k8s-operators:main Oct 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants