Use new nad.EnsureNetworksAnnotation() func to get NAD annotations #1184
Conversation
stuggi
requested review from
olliewalsh and
lmiccini
and removed request for
abays and
viroel
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5d9a4a739bfa4420bffcd0a0a53d9bf2 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 38s |
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure `ipam.gateway` in the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. If `ipam.gateway` is defined and not "", it gets set on the networks annotation as the `default-route`. Jira: https://issues.redhat.com/browse/OSPRH-8680 Depends-On: openstack-k8s-operators/lib-common#579 Signed-off-by: Martin Schuppert <[email protected]>
stuggi
force-pushed
the
nad_annotation_gw
branch
from
b276b5c to
26d2e0e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3486268
into
openstack-k8s-operators:main
|
I think this was forgotten here https://github.com/openstack-k8s-operators/openstack-operator/blame/main/config/manager/kustomization.yaml#L15 |
yes, thanks for the pointer. will be fixed with #1186 |
For BGP setup there is the need to set the default gateway to the additional interface defined via the multus annotations. To allow this a user can configure
ipam.gatewayin the NAD. EnsureNetworksAnnotation() will override the pod network default route by reading the NAD. Ifipam.gatewayis defined and not "", it gets set on the networks annotation as thedefault-route.Jira: https://issues.redhat.com/browse/OSPRH-8680
Depends-On: openstack-k8s-operators/lib-common#579