Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRD schema checker override #1269

Merged
merged 1 commit into from
Jan 21, 2025
+3 −4
Merged

Remove CRD schema checker override #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/dataplane/openstackdataplanenodeset_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,9 +521,9 @@ func checkDeployment(ctx context.Context, helper *helper.Helper,
isDeploymentRunning = true
} else if deploymentConditions.IsTrue(dataplanev1.NodeSetDeploymentReadyCondition) {
// If the nodeset configHash does not match with what's in the deployment and the
// generation metadata has changed i.e generation metatdata won't change when
// generation metadata has changed (i.e generation metatdata won't change when
// fields are removed from the CRD during an update that would not require a new
// deployment to run).
// deployment to run) asssume nodeset has changed requiring new deployment.
if deployment.Status.NodeSetHashes[instance.Name] != instance.Status.ConfigHash &&
generationChanged {
continue
Expand Down
3 changes: 1 addition & 2 deletions hack/crd-schema-checker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ set -euxo pipefail

CHECKER=$INSTALL_DIR/crd-schema-checker

# (TODO) Remove NoFieldRemoval after this PR merges
DISABLED_VALIDATORS=NoMaps,NoFieldRemoval # TODO: https://issues.redhat.com/browse/OSPRH-12254
DISABLED_VALIDATORS=NoMaps # TODO: https://issues.redhat.com/browse/OSPRH-12254

CHECKER_ARGS=""
if [[ ${DISABLED_VALIDATORS:+x} ]]; then
Expand Down
Loading