-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy): adds new public keys table #1836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
jakedoublev
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of work. Thanks for tackling this @strantalis.
fix create key response on invalid key
jakedoublev
reviewed
Jan 22, 2025
I am comfortable approving this now but would like to give others a chance to review as well. |
jakedoublev
approved these changes
Jan 24, 2025
This was referenced Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.24](protocol/go/v0.2.23...protocol/go/v0.2.24) (2025-01-24) ### Features * **policy:** adds new public keys table ([#1836](#1836)) ([cad5048](cad5048)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements the following ADR as discussed here #1485.
public_keys
table along with mappings pivot tables for attribute values, definitions and namespaces.was_mapped
gets set totrue
GetAttributeValueByFQN
rpcKAS_PUBLIC_KEY_ALG_ENUM_RSA_4096
KAS_PUBLIC_KEY_ALG_ENUM_EC_SECP384R1
KAS_PUBLIC_KEY_ALG_ENUM_EC_SECP521R1
Checklist
Testing Instructions