feat(sdk): remove hex encoding for segment hash #397
Conversation
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
| @@ -6,4 +6,5 @@ export type Manifest = { | |||
| payload: Payload; | |||
| encryptionInformation: EncryptionInformation; | |||
| assertions: Assertion[]; | |||
| tdf_spec_version: string; | |||
There was a problem hiding this comment.
it looks like this is importing this file which specifies version 0.2.0 of the TDF spec. Is that what we should be doing in java?
There was a problem hiding this comment.
No, this should somehow be the spec version, which AFAIK is 4.3.0
https://github.com/opentdf/spec/blob/3c5adf29fe9c327b2f85b89e8beee09f0b91d8c7/VERSION
| @@ -6,4 +6,5 @@ export type Manifest = { | |||
| payload: Payload; | |||
| encryptionInformation: EncryptionInformation; | |||
| assertions: Assertion[]; | |||
| tdf_spec_version: string; | |||
There was a problem hiding this comment.
No, this should somehow be the spec version, which AFAIK is 4.3.0
https://github.com/opentdf/spec/blob/3c5adf29fe9c327b2f85b89e8beee09f0b91d8c7/VERSION
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
|
| @@ -1,2 +1,2 @@ | |||
| export const version = '0.2.0'; | |||
| export const version = '4.3.0'; | |||
There was a problem hiding this comment.
The version field is set automatically by the bump-version.sh script, so rename this to either tdfSpecVersion or targetFileFormatVersion or similar
| export const version = '4.3.0'; | |
| export const version = '0.2.0'; | |
| export const tdfSpecVersion = '4.3.0'; |
| @@ -269,26 +271,35 @@ async function _generateManifest( | |||
| // generate the manifest first, then insert integrity information into it | |||
| encryptionInformation: encryptionInformationStr, | |||
| assertions: assertions, | |||
| tdf_spec_version: version, | |||
There was a problem hiding this comment.
| tdf_spec_version: version, | |
| tdf_spec_version: tdfSpecVersion, |
| @@ -4,6 +4,8 @@ import { DecoratedReadableStream } from './client/DecoratedReadableStream.js'; | |||
| import { fetchKasPubKey as fetchKasPubKeyV2, fetchWrappedKey } from '../../src/access.js'; | |||
| import { DecryptParams } from './client/builders.js'; | |||
| import { AssertionConfig, AssertionKey, AssertionVerificationKeys } from './assertions.js'; | |||
| import { version } from './version.js'; | |||
There was a problem hiding this comment.
| import { version } from './version.js'; | |
| import { tdfSpecVersion } from './version.js'; |
No description provided.