Merge pull request #365 from opentween/fix-favorites-tab

Favoritesタブが空のまま更新されない不具合を修正
opentween · Jun 12, 2024 · b49b119 · b49b119
2 parents 22ae58b + bf1696d
commit b49b119
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -3,6 +3,7 @@
 ==== Unreleased
  * NEW: Misskeyでのノート投稿時のファイル添付に対応しました
    - 追加で必要な権限があるため、前バージョンから使用している Misskey アカウントは再度追加し直す必要があります
+ * FIX: Favoritesタブが空のまま更新されない不具合を修正
 
 ==== Ver 3.14.0(2024/06/11)
  * NEW: メインアカウント以外のホームタイムライン表示に対応

diff --git a/OpenTween/SocialProtocol/Twitter/TwitterGraphqlClient.cs b/OpenTween/SocialProtocol/Twitter/TwitterGraphqlClient.cs
@@ -150,7 +150,7 @@ public async Task<TimelineResponse> GetFavoritesTimeline(int count, IQueryCursor
             var cursorTop = response.CursorTop;
             var cursorBottom = response.CursorBottom;
 
-            var posts = this.account.Legacy.CreatePostsFromJson(statuses, firstLoad);
+            var posts = this.account.Legacy.CreatePostsFromJson(statuses, firstLoad, favTweet: true);
 
             var filter = new TimelineResponseFilter(this.account.AccountState);
             posts = filter.Run(posts);

diff --git a/OpenTween/SocialProtocol/Twitter/TwitterV1Client.cs b/OpenTween/SocialProtocol/Twitter/TwitterV1Client.cs
@@ -118,7 +118,7 @@ public async Task<TimelineResponse> GetFavoritesTimeline(int count, IQueryCursor
                 .ConfigureAwait(false);
 
             var (cursorTop, cursorBottom) = GetCursorFromResponse(statuses);
-            var posts = this.account.Legacy.CreatePostsFromJson(statuses, firstLoad);
+            var posts = this.account.Legacy.CreatePostsFromJson(statuses, firstLoad, favTweet: true);
 
             var filter = new TimelineResponseFilter(this.account.AccountState);
             posts = filter.Run(posts);

diff --git a/OpenTween/Twitter.cs b/OpenTween/Twitter.cs
@@ -537,8 +537,11 @@ internal PostClass CreatePostsFromStatusData(TwitterStatus status, bool firstLoa
         }
 
         internal PostClass[] CreatePostsFromJson(TwitterStatus[] statuses, bool firstLoad)
+            => this.CreatePostsFromJson(statuses, firstLoad, favTweet: false);
+
+        internal PostClass[] CreatePostsFromJson(TwitterStatus[] statuses, bool firstLoad, bool favTweet)
         {
-            var posts = statuses.Select(x => this.CreatePostsFromStatusData(x, firstLoad)).ToArray();
+            var posts = statuses.Select(x => this.CreatePostsFromStatusData(x, firstLoad, favTweet)).ToArray();
 
             TwitterPostFactory.AdjustSortKeyForPromotedPost(posts);