Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Add GenAI Node.js bindings #1193

Open
wants to merge 90 commits into
base: master
Choose a base branch
from
Open

[JS] Add GenAI Node.js bindings #1193

wants to merge 90 commits into from
+1,839 −37

Conversation

vishniakov-nikolai
Copy link

@vishniakov-nikolai vishniakov-nikolai commented Nov 11, 2024 •
edited
Loading

Adding Node.js bindings for GenAI pipelines.

  • 155187
  • 158132

Limitations

Current version it's primary backbone of future development. Supports bindings of LLMPipeline only.

TODO

  • Test build configuration
  • Integrate unit tests run into GHA
  • Add script to download runtime binaries (after binaries publication)

@github-actions github-actions bot added category: sampling Sampling / Decoding algorithms category: cmake / build Cmake scripts category: samples GenAI samples labels Nov 11, 2024
@ilya-lavrenov ilya-lavrenov removed the category: sampling Sampling / Decoding algorithms label Nov 20, 2024
@github-actions github-actions bot added the category: tokenizers Tokenizer class or submodule update label Nov 20, 2024
@vishniakov-nikolai vishniakov-nikolai marked this pull request as ready for review November 25, 2024 10:58
@github-actions github-actions bot added category: llm_bench Label for tool/llm_bench folder category: GHA CI based on Github actions labels Nov 26, 2024
ilya-lavrenov
ilya-lavrenov reviewed Jan 16, 2025
View reviewed changes
samples/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov self-requested a review January 16, 2025 12:14
@ilya-lavrenov ilya-lavrenov dismissed their stale review January 16, 2025 12:34

From integration perspective looks OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mryzhov mryzhov mryzhov left review comments

@Wovchena Wovchena Wovchena approved these changes

@as-suvorov as-suvorov Awaiting requested review from as-suvorov

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees

@ilya-lavrenov ilya-lavrenov

@Wovchena Wovchena

Labels
category: cmake / build Cmake scripts category: GHA CI based on Github actions category: samples GenAI samples do_not_merge no-match-files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishniakov-nikolai @Wovchena @ilya-lavrenov @mryzhov