Move tests on sampling to test_sampling.py #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilya-lavrenov
commented
Jan 2, 2025
•
ilya-lavrenov
commented
- Move extensive tests on decoding / sampling from test_llm_pipeline.py tests to test_sampling.py
- Partially refactored common functions in common.py to be more generic (to be continued in next PRs)
- Dropped partially predefined functions with generation configs and replaced them in tests with dict of generation parameters, so you can better see tests params closer to tests itself and avoid creating numerous get_** for new generation values combinations.
- Sampling tests are now implemented on top of stateful model for better comparison with optimum-intel
github-actions
bot
added
category: visual language
ilya-lavrenov
force-pushed
the
sampler-tests
branch
from
44cfb67 to
a107a98
Compare
ilya-lavrenov
force-pushed
the
sampler-tests
branch
from
0d54fde to
dcc434d
Compare
ilya-lavrenov
force-pushed
the
sampler-tests
branch
from
6bb793e to
3c2f171
Compare
github-actions
bot
added
category: WWB
ilya-lavrenov
changed the title
ilya-lavrenov
force-pushed
the
sampler-tests
branch
from
f375c21 to
317b973
Compare
as-suvorov
approved these changes
Jan 3, 2025
ilya-lavrenov
force-pushed
the
sampler-tests
branch
2 times, most recently
from
4e86fba to
7e6cdc2
Compare
ilya-lavrenov
force-pushed
the
sampler-tests
branch
from
7e6cdc2 to
86acac5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.