[CB] Fix Memory leak in CBPipeImpl Constructor #1568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
Reproducer:
Details:
CacheManager
(3GB leak per iteration), Not cleaned block manager ( +2 MB per iteration).CacheManager
andBlockManager
are field of the class). We have anotherScheduler
with virtual destructor. So, compiler can not resolve the class destructor methods, call desctructor from another class and does nothing.Solution:
release
method forScheduler
and call it fromCBPipeImpl
destructor.Additional changes:
cache_manager
field from pipeline because it is using only in schedulerResults: