Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AISE #49

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Support AISE #49

merged 12 commits into from
Jul 30, 2024

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Jul 25, 2024

Support AISE: Adaptive Input Sampling for Explanation of Black-box Models

Preset for black-box methods
Explanation now can take as input a dictionary as well

openvino_xai/explainer/explanation.py Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Outdated Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Outdated Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Outdated Show resolved Hide resolved
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new feature! Looks like WIP, but please keep the unit test coverage > 90% ;)
Left minor comments.

openvino_xai/common/utils.py Outdated Show resolved Hide resolved
openvino_xai/explainer/explanation.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 94.27083% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (b1fd326) to head (fb418c6).

Files Patch % Lines
openvino_xai/methods/black_box/aise.py 96.63% 4 Missing ⚠️
openvino_xai/explainer/explanation.py 76.92% 3 Missing ⚠️
openvino_xai/common/utils.py 93.10% 2 Missing ⚠️
openvino_xai/methods/factory.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
+ Coverage    91.02%   91.59%   +0.56%     
===========================================
  Files           18       19       +1     
  Lines         1070     1213     +143     
===========================================
+ Hits           974     1111     +137     
- Misses          96      102       +6     
Flag Coverage Δ
dev-py310 91.59% <94.27%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@negvet negvet marked this pull request as ready for review July 29, 2024 14:27
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Minor comments are below

CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/user-guide.md Outdated Show resolved Hide resolved
openvino_xai/explainer/explanation.py Outdated Show resolved Hide resolved
docs/source/user-guide.md Show resolved Hide resolved
@GalyaZalesskaya GalyaZalesskaya enabled auto-merge (squash) July 30, 2024 15:38
@GalyaZalesskaya GalyaZalesskaya merged commit 3ca6f09 into openvinotoolkit:develop Jul 30, 2024
6 checks passed
@goodsong81 goodsong81 added this to the 1.1.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants