Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COCO and VOC formats for performance tests #58

Merged

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Aug 29, 2024

  • Follow up minor update for ADCC metric

  • Added COCO and VOC toy datasets for assets

  • Tests passed locally passed
    image

  • Ensured the quality metric numbers from the dataset (COCO and VOC) are the same as quality metrics of the single image

@GalyaZalesskaya
Copy link
Contributor Author

Added additional methods for test_accuracy.py as define_dataset_type, voc_anns_to_gt_bboxes, coco_anns_to_gt_bboxes, DatasetType. Feel free to propose if it's better to move them to tests/utils (not created)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (79c0677) to head (1d328ce).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #58   +/-   ##
========================================
  Coverage    93.57%   93.57%           
========================================
  Files           26       26           
  Lines         1602     1602           
========================================
  Hits          1499     1499           
  Misses         103      103           
Flag Coverage Δ
dev-py310 93.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the long-waited accuracy test! :)
Regarding the test utils, you can choose to create common tests/test_suite directory or keep it as is.
Please see a few comments of mine.

openvino_xai/metrics/adcc.py Outdated Show resolved Hide resolved
tests/perf/test_accuracy.py Show resolved Hide resolved
tests/perf/test_accuracy.py Show resolved Hide resolved
tests/perf/test_accuracy.py Show resolved Hide resolved
Copy link
Collaborator

@negvet negvet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM

@GalyaZalesskaya GalyaZalesskaya enabled auto-merge (squash) August 30, 2024 09:18
@GalyaZalesskaya GalyaZalesskaya merged commit cf77ec4 into openvinotoolkit:develop Aug 30, 2024
6 checks passed
@GalyaZalesskaya GalyaZalesskaya deleted the gz/coco_voc_support branch August 30, 2024 10:00
@GalyaZalesskaya GalyaZalesskaya restored the gz/coco_voc_support branch August 30, 2024 10:07
@goodsong81 goodsong81 added this to the 1.1.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants