Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credo integration #36

Closed
wants to merge 37 commits into from
Closed

Credo integration #36

wants to merge 37 commits into from

Conversation

jrhender
Copy link
Contributor

@jrhender jrhender commented Sep 24, 2024 •
edited
Loading

This PR replaces didKit with Credo for core credential operations.

Remaining TODO items:

  • Decide DB strategy. It likely doesn't make sense to have the exchanges DB be in-memory but the Askar DB be a persistent sqlite.
  • Add ADR documenting the rationale for Credo
  • Adjust documentation
    • Key import/export should be updated for base58 -> opened additional issue to fix: Align Key Import/Export to base58 ids #39
    • Adjust database section of the README (perhaps noting default Askar db location of ~/.afj)
  • Test docker image build and execution, in particular database behaviour on container recreation

ShikharBhatt and others added 27 commits September 11, 2024 09:35
@ShikharBhatt
chore: update rush config and add credo dependencies
7abec03 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
feat(deps): add aries-askar-shared to vc-api
8a064c1 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
feat: add credo askar module
e7e760d 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
feat: integrate credo in did-key-factory
6a19fac 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
feat: integrate credo in key and seeder module
7fbcaf5 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
feat: integrate credo in did module
ef22d27 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: move out env configurations and update readme
1157bb2 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: request changes for PR #1
e133b43 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: make tests compatible with credo
fd1db63 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: add config items to validation scheme
6554c48 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: fix e2e did and key tests
03bb6e1 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: request changes for PR #1
34e64da 
- mock credo service
- fix unit test cases
- remove sample.env file
- fix validation schema

Signed-off-by: ShikharBhatt <[email protected]>
@mesaresachin
feat: Integrate credo in credentials api
121582c 
Signed-off-by: mesaresachin <[email protected]>
@mesaresachin
chore: Restored presentationFrom method to use pex
ea0c22f 
Signed-off-by: mesaresachin <[email protected]>
@mesaresachin
chore: Fixed test cases
961e809 
Signed-off-by: mesaresachin <[email protected]>
@jrhender
chore: move pnpm config to separate file
57a2326 
Needed for rush-pnpm patch-commit to work

Signed-off-by: jrhender <[email protected]>
@jrhender
fix: temporary patch of credo for didAuth presentations
3905a7c 
Ideally, a permanent upstream fix can be made in Credo.

Signed-off-by: jrhender <[email protected]>
@ShikharBhatt
chore: e2e tests
d272c27 
Signed-off-by: ShikharBhatt <[email protected]>
@mesaresachin @ShikharBhatt
chore: Fixed verification result response for credential and presenta…
482c86d 
…tion

- Fixed the test cases

Signed-off-by: mesaresachin <[email protected]>
@ShikharBhatt
chore: cleanup
1df4985 
- remove spruce dependency
-  fix didAuth test case

Signed-off-by: ShikharBhatt <[email protected]>
@jrhender
feat(credentials.service): resuable transfromToCredoPresentation()
c70a602 
Signed-off-by: jrhender <[email protected]>
@ShikharBhatt
fix: request changes for #2
ec00b2f 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
fix: rename the exchange verification result interface
94f5748 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
fix: request changes for #2
d949d4f 
- fix lint issue for any return type

Signed-off-by: ShikharBhatt <[email protected]>
@jrhender
Merge pull request #2 from impactility/credentials-api
2235732 
feat: integrate credo in credentials api
@jrhender
docs: add initial ADR for vc-api
ba50fa7 
Signed-off-by: jrhender <[email protected]>
@jrhender
docs(ADR): add adr 02 for Credo decision
d108705 
Signed-off-by: jrhender <[email protected]>
@jrhender jrhender marked this pull request as ready for review September 27, 2024 13:21
jrhender and others added 9 commits September 30, 2024 04:02
@jrhender
fix(credo.service): use config service
4323ecf 
This gives more flexible on where the config values are loaded from
https://docs.nestjs.com/techniques/configuration

Signed-off-by: jrhender <[email protected]>
@jrhender
refactor: rename ASKAR vars to CREDO
3122202 
Signed-off-by: jrhender <[email protected]>
@ShikharBhatt
chore: use common db for askar and exchanges api
6ec7ed1 
- replace better-sqlite3 with sqlite
- rename in-memory-db.ts to db-config.ts
- TypeOrmSQLiteModule to accept inMemory boolean param; helps in db initialization for app and unit tests

Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
chore: update db paths
47d6352 
Signed-off-by: ShikharBhatt <[email protected]>
@ShikharBhatt
Merge pull request #7 from impactility/db-askar-exchanges
74e12d0 
DB Strategy: Use common db for askar and exchanges
@jrhender
docs(README): remove didkit note
d5f1e08 
Signed-off-by: jrhender <[email protected]>
@jrhender
docs(adr-003): adr for sqlite db choice
a5818ed 
Signed-off-by: jrhender <[email protected]>
@jrhender
docs(VC API README): update DB note
675b739 
Signed-off-by: jrhender <[email protected]>
@jrhender
fix(dockerfile): supporting credo build
9d7ad7d 
Changed from node-alpine to base node.
node-alpine was missing shared library ld-linux-x86-64.so.2.
This lib is required by Askar.

Also removed unneeded package installs.

Signed-off-by: jrhender <[email protected]>
@jrhender jrhender mentioned this pull request Oct 1, 2024
Merged
@jrhender
Copy link
Contributor Author

jrhender commented Oct 3, 2024

Closing at #38 is merged instead

@jrhender jrhender closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrhender @ShikharBhatt @mesaresachin