-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix many issues with examples #669
Conversation
@stxue1 @adamnovak would also appreciate your reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like everything should work.
Lines 4703 to 4705 in 20ff54d
I'm not too certain what the expected output should be. MiniWDL currently returns {
"input_hint.experience": []
} |
This has also been resolved. Based on this, I think the PR is good to go, and I'm going to merge it. This PR has sat for a second, so I did the best I could with making sure nothing was missed, but feel free to file another issue if anything wasn't pulled in correctly. |
This commit fixes multiple issues in the `v1.1.*` specification. Many (if not all) of the tests were surfaced and reported by @stxue1. The fixes for these tests were a combination of effort from @stxue1 and @jdidion. @adamnovak added feedback on the PR that further refined the tests. @claymcleod did the final review and merge of the pull request in #669. Closes #653. Closes #654. Closes #661. Closes #662. Closes #663. Closes #664. Closes #665. Closes #666. Closes #667. Closes #668. Co-authored-by: Clay McLeod <[email protected]> Co-authored-by: John Didion <[email protected]> Co-authored-by: Adam Novak <[email protected]>
Closes #653.
Closes #654.
Closes #661.
Closes #662.
Closes #663.
Closes #664.
Closes #665.
Closes #666.
Closes #667.
Closes #668.
Checklist