-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
52 python dependencies to requirements #60
base: main
Are you sure you want to change the base?
52 python dependencies to requirements #60
Conversation
Added all dependencies, such as Flask, Werkzeug, and uwsgi, into this file to keep things organized.
Adjusted the Ansible tasks to install dependencies from requirements.txt instead of listing them directly in the file & updated pip and related tools like setuptools and wheel.
tasks/pip.yml
Outdated
- name: Install Flask, Werkzeug and uWSGI | ||
- name: Read local requirements.txt | ||
local_action: command cat requirements.txt | ||
register: requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is correct? Did you try running the tests locally?
https://github.com/openwisp/ansible-wireguard-openwisp?tab=readme-ov-file#how-to-run-tests
Using `{{ role_path }}` instead of absolute paths, this variable points to the root directory of our Ansible role, where requirements.txt is located.
@pandafy , I've fixed the path for requirements.txt file, now it's working.. can you please check nd lmk, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below, please also take a look at the message returned by the QA checks failure regarding the lack of capital letter after the square bracket, eg:
[prefix] done something
should be [prefix] Done something
.
- wheel | ||
- attrs | ||
- importlib-metadata | ||
- packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't move these because we're always upgrade to the latest version available.
The aim is to move only the python packages that we are pinning to as pecific version range, so that dependabot can help us update those more with less intervention from our end.
Checklist
Reference to Existing Issue
Closes #52.
Description of Changes
This pull request moves Python dependencies from
pip.yml
to arequirements.txt
file for easier management. Here’s what was done:Created a
requirements.txt
file:Flask
,Werkzeug
, anduwsgi
, into this file to keep things organized.Updated
pip.yml
:requirements.txt
instead of listing them directly in the file.pip
and related tools likesetuptools
andwheel
.requirements.txt
file.Dependabot Integration:
requirements.txt
automatically.Tested the Changes:
These changes make it easier to manage and update dependencies while keeping the setup clean and consistent.