Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Suggest correct vpn hostname in auto-install script #420

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[fix] Suggest correct vpn hostname in auto-install script #420

merged 1 commit into from
Dec 23, 2024

Conversation

youhaveme9
Copy link
Contributor

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #419

@youhaveme9 youhaveme9 force-pushed the issue/419-suggest-correct-hostname branch from b1bdb12 to d05a21b Compare December 20, 2024 08:31
@youhaveme9
Copy link
Contributor Author

Hey @pandafy
Can't figure out why the test is failing
I think it is related to issue #347

@pandafy pandafy changed the title [fix] suggest correct vpn hostname in auto-install script [fix] Suggest correct vpn hostname in auto-install script Dec 23, 2024
@nemesifier nemesifier merged commit f8156d6 into openwisp:master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenWISP Contributor's Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Suggest correct hostname for OpenVPN in auto-install script
2 participants
@youhaveme9 @nemesifier