Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Commit check now work on github actions #163 #364

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

praptisharma28
Copy link
Member

@praptisharma28 praptisharma28 commented Nov 25, 2023

Closes #163

Changes

Updated the script to check commit messages to work with GitHub Actions.
Used the GITHUB_ACTIONS and GITHUB_EVENT_NAME environment variables to determine if the script is running in a GitHub >Actions workflow triggered by a pull request.
Skipped the commit message check if the workflow is triggered by a pull request.

Screenshots

#For UI changes, please share a screenshot#

Checklist

  • I have read the contributing guidelines.
  • I have manually tested the proposed changes.
  • I have written new test cases to avoid regressions. (if necessary)
  • I have updated the documentation. (e.g. README.rst)
  • I have added [change!] to commit title to indicate a backward incompatible change. (if required)
  • I have checked the links added / modified in the documentation.

#Closes #163 #

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 98.175%. remained the same
when pulling cfdb341 on praptisharma28:githubactions
into 746b146 on openwisp:master.

@pandafy pandafy requested a review from nemesifier November 27, 2023 11:36
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove those lines. The merge commit exception is already handled in the python code, that if is redundant.

@praptisharma28
Copy link
Member Author

praptisharma28 commented Nov 29, 2023

Ok @nemesifier , I have removed the lines.
Link: cfdb341

@pandafy pandafy requested a review from nemesifier November 29, 2023 09:24
Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @praptisharma28, LGTM!

In your future PRs. please pay attention to OpenWISP's branch naming conventions

if there's an issue your patch addresses
git checkout -b issues/48-issue-title-shortened

Read more here https://openwisp.io/docs/developer/contributing.html#branch-naming-guidelines

@nemesifier nemesifier merged commit e177b7d into openwisp:master Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[qa] Does commit check work on github actions?
4 participants