Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Switched to prettier #425

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

youhaveme9
Copy link
Contributor

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #367

@youhaveme9 youhaveme9 force-pushed the issues/367-switch-to-prettier branch from ceafd50 to 52bcd9f Compare December 24, 2024 16:00
@coveralls
Copy link

coveralls commented Jan 9, 2025

Coverage Status

coverage: 96.18%. remained the same
when pulling efc11db on youhaveme9:issues/367-switch-to-prettier
into 1103df5 on openwisp:master.

@pandafy pandafy requested a review from nemesifier January 13, 2025 10:01
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I am testing.
We will need to update this page too:
https://openwisp.io/docs/dev/developer/contributing.html#javascript-code-conventions

We need to update the javascript code conventions section and add a new section for CSS.

This is the file that needs to be edited:
https://github.com/openwisp/openwisp-docs/blob/master/developer/contributing.rst

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the changes on OpenWISP Controller:
openwisp/openwisp-controller#969.

@youhaveme9
Copy link
Contributor Author

Looks good, I am testing. We will need to update this page too: https://openwisp.io/docs/dev/developer/contributing.html#javascript-code-conventions

We need to update the javascript code conventions section and add a new section for CSS.

This is the file that needs to be edited: https://github.com/openwisp/openwisp-docs/blob/master/developer/contributing.rst

PR incoming!

@youhaveme9
Copy link
Contributor Author

Hey @nemesifier
Should we combine the CSS and JS section in the docs in one single section as prettier is used for both?

@nemesifier
Copy link
Member

Hey @nemesifier Should we combine the CSS and JS section in the docs in one single section as prettier is used for both?

I think in this case is ok to combine them since we use one tool for both.

@youhaveme9
Copy link
Contributor Author

Hey @nemesifier Should we combine the CSS and JS section in the docs in one single section as prettier is used for both?

I think in this case is ok to combine them since we use one tool for both.

openwisp/openwisp-docs#217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

[change] Switch to prettier to check and fix JS/CSS
3 participants