[GR-54978] [GR-59135 ] Report unrecognized/ill-formed hosted options in NI driver #10485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly improves reporting of unknown or ill-formed hosted options in the driver.
For a bougus command line like
native-image -H:UnlockExperimentalVMOptions -H:+UnlockExperimentalOptions -H:-StaticExecutable -H:-UnlockExerimentalVMOptions --macro:jvmcicompiler-library
, instead of showing incorrect & misleading results likethat make the user think those are actual NI options, we now get
after fixing the command line we show
Any hosted option that the builder does not support is immediately reported. The driver now also provides suggestions how to fix options that are misspelled or have invalid syntax. And all of that happens without ever calling the builder.