-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52942] Add JFR events and track peak usage for native memory tracking. #8462
Conversation
2bc5cdf
to
e76be3c
Compare
I've added 2 native image specific events to expose peak tracking information: |
81130f0
to
2aab9f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, most parts look good. Before I integrate this PR, please squash all your commits (it seems that most commits are just fixup commits and don't have a dedicated purpose).
Please note that I plan to do a few cleanups and fixes on top before integration.
add peak tracking and tests
2aab9f9
to
06c6404
Compare
Thanks @christianhaeubl ! I've updated the PR with the commits squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We had some internal discussions regarding the Native Image-specific events. I marked the events as Please have a look at my PR and let me know if you think that any of those changes are an issue: #8668. |
This pull request adds JFR events for recently added native memory tracking.
It also adds tracking of peak malloc usage. Unfortunately, the stock NMT JFR events from the openJDK do not contain peak usage data. So the only way to view the peak usage data is by specifying
-XX:+PrintNMTStatistics
at runtime. Another possibility is to add Native Image specificNativeMemoryUsagePeak
events.See issue: #8452