-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52456] Add nightly workflow for Spring. #8510
Conversation
export JAVA_HOME=${LABSJDK_HOME} | ||
cd substratevm | ||
${MX_PATH}/mx --native=native-image,lib:jvmcicompiler --components="Native Image,LibGraal" build | ||
mv $(${MX_PATH}/mx --native=native-image,lib:jvmcicompiler --components="Native Image,LibGraal" graalvm-home) ${GRAALVM_HOME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shared action no longer builds libgraal. It's actually not used when running a Native Image build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting. When did that change? Last time I checked libgraal was being used by GraalVM CE see graalvm#288 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing changed, what I meant is that the compilation stage in Native Image uses jargraal anyway (it adds additional AOT-specific phases etc that would otherwise require recompilation of libgraal). Yes, libgraal would probably improve performance a bit when compiling jargraal, but building it probably takes more time in CI than it saves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so if I get this right:
-
It's still being used (if present) by the native-image generator (the java process which runs on GraalVM) but it's just used to run that process and is not being used to AOT compile the native image.
-
Since GraalVM with libgraal is being tested extensively in other places there is no reason for testing it in this context as well.
- name: Run nativeTest in spring-petclinic | ||
run: | | ||
cd ${{ env.SPRING_PETCLINIC_PATH }} | ||
./gradlew nativeTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @sdeleuze
and refactor other microservices workflows.