[GR-50266] [GR-51136] Fix some missing Truffle requirements for Espresso. by graalvmbot · Pull Request #8584 · oracle/graal

Fix 2 bugs: - A foreign null does not succeed a cast to primitive - Bytecode node get their source section from their root.

rakachan

committed

Frame.getValue(slot) does not work with static slots. For verifying purposes, trust static slot usages.

rakachan

committed

Check that the object slot of static frame slots is the default value on entering roots.

rakachan

committed

Abide by truffle expectations that frames should be clean on entering root nodes.

rakachan

committed

Make static slots tag initialize to 0.

rakachan

committed

Exploit the fact that uninitialized static frame slots return 0 on accesses to always have a defined BCI.

rakachan

committed

Propagate new frame static slot initialization handling changes to the compiler side.

rakachan

committed

Fix typo, and remove unused constants.

rakachan

committed

Make some FrameDescriptor fields as immutable during Truffle host compilations.

rakachan

committed

Add possibility to easily remove assertions from subprocess tests. Use it to ensure consistent handling of uninitialized static slots.

rakachan

committed

Update FrameHostReadsTest using assertion disabled.

rakachan

committed

Adds an assertion in frame access node to fail early when static slots are not correctly used. Also adds comments for clarity.

rakachan

committed

Remove intrinsification of 'isStatic'

rakachan

committed

More precise handling of static slot transfer during bytecode OSR. Static slots always transfer as static, even if uninitialized.

rakachan

committed

ClearPrimitiveEffect in FrameAccessVerification uses correct access flag.

rakachan

committed

Style fixes: use multi-line comment, remove useless whitespace, invert if condition.

rakachan

committed

Adds precision to Frame documentation.

rakachan

committed

Adds profiles to ToEspressoNode.

rakachan

committed

Add changelog entry for uninitialized static slot behavior.

rakachan

committed

restore and deprecate static-mode related fields in FrameDescriptor

rakachan

committed

Use InlinedBranchProfile instead of regular BranchProfile

rakachan

committed

Use reflection to check for frame assertions disabled. Fixes test called in BytecodeOSRTest. Typo fix in FrameHostReads test comment.

rakachan

committed

Use byte static slot to differentiate uninit/Regular/OSR state, rather than 2-state boolean.

rakachan

committed

Remove isStatic check from isObject, and make it an assert for all `isType` methods. Update documentation to specify not to trust `isType` on static slots.

rakachan

committed

Fix frame slot type verification in tests.

rakachan

committed

Frame assertions checking is delegated to a helper method. Use GraalError.guarantee instead of assert in compiler.

rakachan

committed

Update header years.

rakachan

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GR-50266] [GR-51136] Fix some missing Truffle requirements for Espresso.#8584

Commits on Mar 21, 2024

Fix 2 bugs: - A foreign null does not succeed a cast to primitive - Bytecode node get their source section from their root.

Frame.getValue(slot) does not work with static slots. For verifying purposes, trust static slot usages.

Check that the object slot of static frame slots is the default value on entering roots.

Abide by truffle expectations that frames should be clean on entering root nodes.

Make static slots tag initialize to 0.

Exploit the fact that uninitialized static frame slots return 0 on accesses to always have a defined BCI.

Propagate new frame static slot initialization handling changes to the compiler side.

Fix typo, and remove unused constants.

Make some FrameDescriptor fields as immutable during Truffle host compilations.

Add possibility to easily remove assertions from subprocess tests. Use it to ensure consistent handling of uninitialized static slots.

Update FrameHostReadsTest using assertion disabled.

Adds an assertion in frame access node to fail early when static slots are not correctly used. Also adds comments for clarity.

Remove intrinsification of 'isStatic'

More precise handling of static slot transfer during bytecode OSR. Static slots always transfer as static, even if uninitialized.

ClearPrimitiveEffect in FrameAccessVerification uses correct access flag.

Style fixes: use multi-line comment, remove useless whitespace, invert if condition.

Adds precision to Frame documentation.

Adds profiles to ToEspressoNode.

Add changelog entry for uninitialized static slot behavior.

restore and deprecate static-mode related fields in FrameDescriptor

Use InlinedBranchProfile instead of regular BranchProfile

Use reflection to check for frame assertions disabled. Fixes test called in BytecodeOSRTest. Typo fix in FrameHostReads test comment.

Use byte static slot to differentiate uninit/Regular/OSR state, rather than 2-state boolean.

Remove isStatic check from isObject, and make it an assert for all `isType` methods. Update documentation to specify not to trust `isType` on static slots.

Fix frame slot type verification in tests.

Frame assertions checking is delegated to a helper method. Use GraalError.guarantee instead of assert in compiler.

Update header years.