Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-57998] Remove ComputedValueField and ReadableJavaField. #9634

Closed
wants to merge 1 commit into from

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Sep 7, 2024

Now that we have proper FieldValueTransformer, it is no longer necessary to also have ComputedValueField to do the transformations for @RecomputeFieldValue annotations. Instead, AnnotationSubstitutionProcessor now registers field value transformer too.
Only for the weird and historic final field semantics of @Alias fields, it is still necessary to have AliasField in the substitution universe. But AliasField is much simpler than the old ComputedValueField.

With ComputedValueField gone, there is also no need for ReadableJavaField.

In addition, there is also no longer a need for the Availability enum in FieldValueTransformerWithAvailabiliy. A simple boolean isAvailable method is sufficient and more flexible.

This PR should not have much impact on analysis or code quality. There is only a slight possible benefit: the field value transformer for FieldOffset transformations allows intrisification before the analysis, which can turn a few unsafe field accesses back into regular field access nodes.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 7, 2024
@graalvmbot graalvmbot changed the title [GR-57998] Remove ComputedValueField and ReadableValueField. [GR-57998] Remove ComputedValueField and ReadableJavaField. Sep 9, 2024
@graalvmbot graalvmbot force-pushed the cwi/GR-57998-ReadableValueField branch from 0a313a6 to ba5ff1c Compare September 11, 2024 14:43
@graalvmbot graalvmbot closed this Sep 13, 2024
@graalvmbot graalvmbot deleted the cwi/GR-57998-ReadableValueField branch September 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants