Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the log message in repo finder #533

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

behnazh-w
Copy link
Member

@behnazh-w behnazh-w commented Oct 27, 2023

When the purl string's type, which is provided as input is not a repository, we should not log it as an error. This PR changes the log level and improves the log message.

@behnazh-w behnazh-w added the repository_finder The issues related to the repository finder label Oct 27, 2023
@behnazh-w behnazh-w requested a review from benmss October 27, 2023 01:19
@behnazh-w behnazh-w requested a review from tromai as a code owner October 27, 2023 01:19
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 27, 2023
@tromai
Copy link
Member

tromai commented Oct 27, 2023

I think this change has been made by @benmss in this PR 🤔 . Is this because we want to split it into a separate PR for clarity?

@behnazh-w
Copy link
Member Author

I think this change has been made by @benmss in this PR 🤔 . Is this because we want to split it into a separate PR for clarity?

I hadn't noticed the change in that PR, but since it is still in progress, it's better to fix the log sooner.

@behnazh-w behnazh-w merged commit ba3b617 into staging Oct 27, 2023
10 checks passed
@behnazh-w behnazh-w deleted the logs-repofinder branch October 27, 2023 06:04
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. repository_finder The issues related to the repository finder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants