Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading through some code, I realized the examples in some docstrings are wrong. These should have been caught by
doctest
.Currently in
pyproject.toml
,pytest
is configured as follows:Although the
--doctest-modules
flag is enabled, meaningdoctest
should run,testpaths
is limited to only thetests
directory. This does not allowdoctest
to pick up the docstring examples insrc/macaron
.In this PR, I enable
doctest
to discover docstring examples insrc/macaron
as follows:testpaths = [ + "src/macaron", # this is included to run doctest on examples "tests", ]
I also fix cases where the example fails
doctest
. There are commonly two reasons why these examples fail:doctest
picks up, to using a Python code block.