-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPDEVTOOL-5872 Release JS Tools #873
base: dev
Are you sure you want to change the base?
DPDEVTOOL-5872 Release JS Tools #873
Conversation
@carolnavarropereira Don't we have anything to update on @carolnavarropereira reply: Error [ERR_REQUIRE_ESM]: require() of ES Module (...) is not supported. Instead change the require of inquirer.js in (...) to a dynamic import() which is available in all CommonJS modules. |
"@typescript-eslint/eslint-plugin": "7.17.0", | ||
"@typescript-eslint/parser": "7.17.0", | ||
"@types/mocha": "10.0.10", | ||
"@types/node": "22.10.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Changed to 20.17.14
This is the higher version of 20 for types/node
"@typescript-eslint/parser": "7.17.0", | ||
"@types/mocha": "10.0.10", | ||
"@types/node": "22.10.6", | ||
"@types/vscode": "1.96.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the right version for it, but we should also update line 23 to match the same version. I also think we won't be able to build the extension file (.vsix) if these values are not in sync.
"engines": {
"vscode": "^1.91.1"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, should we update the line 23? (I think it is the best option)
Updated line 23 to 1.96.0
Upgrade library versions