Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDEVTOOL-5872 Release JS Tools #873

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

carolnavarropereira
Copy link
Member

Upgrade library versions

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 15, 2025
@davidecorreu
Copy link
Member

davidecorreu commented Jan 16, 2025

@carolnavarropereira Don't we have anything to update on packages/node-cli/package.json ?

@carolnavarropereira reply:
chalk, commander and inquirer have newer versions but we cannot update them because it would required to configuration the setup of the application for all the packages

Error [ERR_REQUIRE_ESM]: require() of ES Module (...) is not supported. Instead change the require of inquirer.js in (...) to a dynamic import() which is available in all CommonJS modules.

"@typescript-eslint/eslint-plugin": "7.17.0",
"@typescript-eslint/parser": "7.17.0",
"@types/mocha": "10.0.10",
"@types/node": "22.10.6",
Copy link
Member

@davidecorreu davidecorreu Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should go for @types/node in sync with vscode node version which currently is 20.
Screenshot 2025-01-16 at 09 27 39

Copy link
Member Author

@carolnavarropereira carolnavarropereira Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Changed to 20.17.14
This is the higher version of 20 for types/node

"@typescript-eslint/parser": "7.17.0",
"@types/mocha": "10.0.10",
"@types/node": "22.10.6",
"@types/vscode": "1.96.0",
Copy link
Member

@davidecorreu davidecorreu Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right version for it, but we should also update line 23 to match the same version. I also think we won't be able to build the extension file (.vsix) if these values are not in sync.

	"engines": {
		"vscode": "^1.91.1"
	},

Copy link
Member Author

@carolnavarropereira carolnavarropereira Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, should we update the line 23? (I think it is the best option)
Updated line 23 to 1.96.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants