Adding AWS S3 Configuration Provider and AWS Secrets Manager Provider #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: ojdbc-provider-aws/pom.xml new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/authentication/AwsAuthenticationMethod.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/authentication/AwsBasicCredentialsFactory.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSAppConfigProvider.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSAppConfigurationURLParser.java new file: ojdbc-provider-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AWSConfigurationParameters.java modified: ojdbc-provider-aws/src/main/resources/META-INF/services/oracle.jdbc.spi.OracleConfigurationProvider new file: ojdbc-provider-samples/src/main/java/oracle/jdbc/provider/aws/configuration/SimpleAWSAppConfigExample.java
oracle-contributor-agreement
bot
added
the
OCA Verified
psilberk
reviewed
Jan 17, 2025
|
|
||
| // Sample default URL if non present | ||
| if (args.length == 0) { | ||
| url = "jdbc:oracle:thin:@config-awss3://{bucket-name}/{key-name}"; |
There was a problem hiding this comment.
It's true the AWS calls the file "key" but would it be easier to understand {file-name} instead of key?
And actually it could be
url = "jdbc:oracle:thin:@config-awss3://{S3-URI}";
maybe with a comment
url = "jdbc:oracle:thin:@config-aws{S3-URI}"; is valid too:
There was a problem hiding this comment.
I think with a sample (like "mybucket/myconfigfile.json") could be easier to follow
psilberk
reviewed
Jan 17, 2025
| <dependency> | ||
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc-provider-aws</artifactId> | ||
| <version>1.2.0</version> |
psilberk
reviewed
Jan 17, 2025
| The Oracle DataSource uses a new prefix `jdbc:oracle:thin:@config-awss3:` to be able to identify that the configuration parameters should be loaded using AWS S3. Users only need to indicate the S3 URI of the object that contains the JSON payload, with the following syntax: | ||
|
|
||
| <pre> | ||
| jdbc:oracle:thin:@config-awass3://{s3-uri} |
There was a problem hiding this comment.
typo on awa
maybe we can also point out the optional aws{s3 uri}
psilberk
reviewed
Jan 17, 2025
| @@ -0,0 +1,88 @@ | |||
| ################################################################################ | |||
There was a problem hiding this comment.
I think this is the THIRD_PARTY_LICENSES.txt
psilberk
reviewed
Jan 17, 2025
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>appconfig</artifactId> |
psilberk
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining the work by @psilberk into this branch.
This branch adds the following Configuration Providers for AWS Services: