Add support for parsing OrgProperties from any string #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberin
requested review from
alensiljak,
stefan2904,
colonelpanic8 and
cbkerr
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 25, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 25, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 25, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 25, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
colonelpanic8
approved these changes
Dec 26, 2024
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 27, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 27, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 27, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
amberin
added a commit
to amberin/orgzly-android-revived
that referenced
this pull request
Dec 28, 2024
This presupposes orgzly-revived/org-java#6. Linking to notebooks via their "ID" property now works. I did not touch the handling of the preface, so the book properties are visible as part of the preface content. This means they can be shown and edited in Orgzly without changing the current GUI. It feels a bit hacky, but it could be a first, simple implementation of book properties, which I suppose could later be improved by adding a "edit book properties" menu choice, similar to today's "edit preface". Book properties are stored in a separate DB table, just like note properties. They are only parsed and stored when loading books from files and when the preface has been edited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for orgzly-revived/orgzly-android-revived#174.