Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Make the poseidon to be a separated package #77

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Feature/Make the poseidon to be a separated package #77

merged 5 commits into from
Aug 22, 2024

Conversation

NOOMA-42
Copy link
Contributor

@NOOMA-42 NOOMA-42 commented Aug 2, 2024 •
edited
Loading

Description

Make the poseidon hash to be a separated package

Related issue

#76

Testing

cd zkmemory
cargo test
cd poseidon
cargo test

chiro-hiro
chiro-hiro reviewed Aug 3, 2024
View reviewed changes
poseidon/LICENSE Outdated Show resolved Hide resolved
@NOOMA-42 NOOMA-42 force-pushed the feat/poseidon-as-package branch from 9571214 to 26c382f Compare August 20, 2024 20:30
@NOOMA-42 NOOMA-42 force-pushed the feat/poseidon-as-package branch from 26c382f to 49d7723 Compare August 20, 2024 20:38
phamnhatminh1292001
phamnhatminh1292001 approved these changes Aug 22, 2024
View reviewed changes
zkmemory/src/commitment/merkle_tree.rs Outdated Show resolved Hide resolved
zkmemory/src/commitment/verkle_tree.rs Outdated Show resolved Hide resolved
poseidon/examples/poseidon_hash.rs Outdated Show resolved Hide resolved
@phamnhatminh1292001 phamnhatminh1292001 merged commit 25b08c2 into orochi-network:main Aug 22, 2024
4 checks passed
@NOOMA-42 NOOMA-42 deleted the feat/poseidon-as-package branch August 22, 2024 10:13
@NOOMA-42 NOOMA-42 mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiro-hiro chiro-hiro chiro-hiro left review comments

@phamnhatminh1292001 phamnhatminh1292001 phamnhatminh1292001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NOOMA-42 @chiro-hiro @phamnhatminh1292001