chore(tests): Increase test coverage

https://app.codecov.io/gh/ory/oathkeeper/pull/1153
ory · Mar 3, 2024 · 83f4387 · 83f4387
1 parent 55254d1
commit 83f4387
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/pipeline/authn/authenticator_delegate.go b/pipeline/authn/authenticator_delegate.go
@@ -23,17 +23,13 @@ func (a *AuthenticatorDelegate) GetID() string {
 	return "delegate"
 }
 
-func (a *AuthenticatorDelegate) Validate(config json.RawMessage) error {
+func (a *AuthenticatorDelegate) Validate(_ json.RawMessage) error {
 	if !a.c.AuthenticatorIsEnabled(a.GetID()) {
 		return NewErrAuthenticatorNotEnabled(a)
 	}
-
-	if err := a.c.AuthenticatorConfig(a.GetID(), config, nil); err != nil {
-		return NewErrAuthenticatorMisconfigured(a, err)
-	}
 	return nil
 }
 
-func (a *AuthenticatorDelegate) Authenticate(r *http.Request, session *AuthenticationSession, config json.RawMessage, _ pipeline.Rule) error {
+func (a *AuthenticatorDelegate) Authenticate(r *http.Request, _ *AuthenticationSession, _ json.RawMessage, _ pipeline.Rule) error {
 	return ErrAuthenticatorDelegate
 }
diff --git a/proxy/proxy_test.go b/proxy/proxy_test.go
@@ -437,12 +437,7 @@ func TestProxy(t *testing.T) {
 			rulesRegexp: []rule.Rule{ruleDelegateAuthenticator},
 			rulesGlob:   []rule.Rule{ruleDelegateAuthenticatorGlob},
 			code:        http.StatusOK,
-			transform: func(r *http.Request) {
-				r.Header.Add("Authorization", "bearer token")
-			},
 			messages: []string{
-				"authorization=bearer token",
-				"url=/authn-delegate/1234",
 				"host=" + x.ParseURLOrPanic(backend.URL).Host,
 			},
 		},
@@ -452,12 +447,7 @@ func TestProxy(t *testing.T) {
 			rulesRegexp: []rule.Rule{ruleDelegateAuthenticatorModifyUpstream},
 			rulesGlob:   []rule.Rule{ruleDelegateAuthenticatorModifyUpstreamGlob},
 			code:        http.StatusOK,
-			transform: func(r *http.Request) {
-				r.Header.Add("Authorization", "bearer token")
-			},
 			messages: []string{
-				"authorization=bearer token",
-				"url=/authn-delegate/1234",
 				"host=" + x.ParseURLOrPanic(ts.URL).Host,
 			},
 		},