Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add --pull=newer #21

Merged
merged 1 commit into from
Dec 5, 2023
Merged

README: add --pull=newer #21

merged 1 commit into from
Dec 5, 2023

Conversation

vrothberg
Copy link
Contributor

To make sure Podman is updating the image if a newer one is on the registry. The image doesn't specify a tag, so Podman should defailt to :latest which should imply --pull=newer.

I will take a look whether there's a Podman bug.

@ondrejbudai ondrejbudai enabled auto-merge December 1, 2023 10:29
@vrothberg
Copy link
Contributor Author

Correction on my end, :latest does not default to pulling down the image. Only Kubernetes does that but not Docker or Podman.

auto-merge was automatically disabled December 1, 2023 13:47

Merge queue setting changed

@rhatdan
Copy link
Contributor

rhatdan commented Dec 5, 2023

LGTM

@rhatdan
Copy link
Contributor

rhatdan commented Dec 5, 2023

Lets get this merged.

To make sure Podman is updating the image if a newer one is on the
registry.  The image doesn't specify a tag, so Podman should defailt to
`:latest` which should imply `--pull=newer`.

I will take a look whether there's a Podman bug.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Contributor Author

Updated, we also need to update the tier-1 image to the new reference. Can do that later.

@ondrejbudai ondrejbudai merged commit 6d671b7 into osbuild:main Dec 5, 2023
3 of 4 checks passed
@vrothberg vrothberg deleted the pull branch December 5, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants