Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib: add a new gce image type (COMPOSER-2358) #646

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Sep 12, 2024

This commit adds a new image type raw-tgz that contains a tar
file with the raw image inside. This was requested by GCP.

See also osbuild/images#923
This will need osbuild/osbuild#1886 first.

@henrywang
Copy link
Member

Hi @mvo5, do we still need this image type exposed if it's just a middle type of GCP image? Thanks.

@mvo5
Copy link
Collaborator Author

mvo5 commented Sep 13, 2024

Hi @mvo5, do we still need this image type exposed if it's just a middle type of GCP image? Thanks.

Thanks - I honestly don't know, I'm not 100% what the use-case is and the name raw-tgz is just a strawman for now. I'm happy to tweak how this is exposed to the user. Is there a github issue or jira ticket to read more about the background?

@mvo5 mvo5 changed the title bib: add a new raw-tgz image type bib: add a new gce image type Sep 17, 2024
@mvo5 mvo5 force-pushed the raw-tgz branch 3 times, most recently from 9d06575 to 1377c59 Compare September 17, 2024 18:54
@ondrejbudai ondrejbudai changed the title bib: add a new gce image type bib: add a new gce image type (COMPOSER-2358) Sep 23, 2024
@mvo5 mvo5 force-pushed the raw-tgz branch 4 times, most recently from cec1ea0 to 897d38c Compare October 1, 2024 08:05
@mvo5 mvo5 marked this pull request as ready for review October 1, 2024 08:18
@mvo5 mvo5 force-pushed the raw-tgz branch 2 times, most recently from 824e250 to be2e5ed Compare October 8, 2024 08:15
achilleas-k
achilleas-k previously approved these changes Oct 8, 2024
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tiny question.

README.md Outdated Show resolved Hide resolved
This commit adds a new image type `gce` that contains a tar
file with the raw image inside. This can then be imported
into GCE.
@achilleas-k achilleas-k added this pull request to the merge queue Oct 8, 2024
Merged via the queue into osbuild:main with commit a36a254 Oct 8, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants