Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-arch *4 support #662

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Multi-arch *4 support #662

merged 1 commit into from
Oct 7, 2024

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Sep 29, 2024

Producing a multi-arch image build on the following arches: amd64, arm64, ppc64le and s390x

@lmilbaum lmilbaum self-assigned this Sep 29, 2024
@lmilbaum lmilbaum force-pushed the multiarch branch 18 times, most recently from d0c625c to 1242d74 Compare October 4, 2024 13:09
@lmilbaum lmilbaum marked this pull request as ready for review October 4, 2024 13:30
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Oct 4, 2024

/retest

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Oct 6, 2024

@ondrejbudai @achilleas-k Please take a look at the CI failures. centos-bootc images multiarch support will be unlocked as soon as this PR is merged and an new quay.io/centos-bootc/bootc-image-builder image lands.

@mvo5
Copy link
Collaborator

mvo5 commented Oct 7, 2024

This seems to fail because of a recent API change in the "images" library, this PR #665 fix this and once rebased this test should pass.

@lmilbaum
Copy link
Contributor Author

lmilbaum commented Oct 7, 2024

This seems to fail because of a recent API change in the "images" library, this PR #665 fix this and once rebased this test should pass.

Thanks @mvo5 for your feedback. Is it safe to merge this PR even before the other fix has landed?

@achilleas-k
Copy link
Member

#665 is in the merge queue. We can rebase once it's merged to make sure the configs in this PR work.

@lmilbaum lmilbaum enabled auto-merge October 7, 2024 14:03
@lmilbaum lmilbaum added this pull request to the merge queue Oct 7, 2024
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Merged via the queue into osbuild:main with commit 0faec5b Oct 7, 2024
9 of 10 checks passed
@lmilbaum lmilbaum deleted the multiarch branch October 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants