Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscap: change oscap file to typeSript file #1534

Closed
wants to merge 1 commit into from

Conversation

mgold1234
Copy link
Collaborator

this commit convert oscap file from JavaScript to TypeScript

@mgold1234 mgold1234 marked this pull request as draft January 7, 2024 19:37
@mgold1234 mgold1234 force-pushed the convert_oscap_to_typeScrip branch from 5a6c80d to ccd6b65 Compare January 7, 2024 19:43
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ac435d) 77.69% compared to head (1be088d) 76.76%.
Report is 20 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   77.69%   76.76%   -0.93%     
==========================================
  Files          69       68       -1     
  Lines        2035     1971      -64     
  Branches      560      549      -11     
==========================================
- Hits         1581     1513      -68     
- Misses        413      417       +4     
  Partials       41       41              

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac435d...1be088d. Read the comment docs.

this commit convert oscap file from JavaScript to TypeScript
@mgold1234 mgold1234 force-pushed the convert_oscap_to_typeScrip branch from ccd6b65 to 1be088d Compare January 9, 2024 10:06
@mgold1234
Copy link
Collaborator Author

we will not convert to patternFly 5

@mgold1234 mgold1234 closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant