Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2Wizard: Add Repositories step #1569

Merged
merged 6 commits into from
Jan 26, 2024
Merged

V2Wizard: Add Repositories step #1569

merged 6 commits into from
Jan 26, 2024

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 18, 2024 •
edited
Loading

This PR adds Repository step to the V2Wizard. Files were migrated to TypeScript, new directory was created for utilities that are used across more steps and .content test suite was added and updates so only relevant tests are enabled.

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46ac78b) 77.40% compared to head (79b6627) 77.38%.
Report is 22 commits behind head on main.

❗ Current head 79b6627 differs from pull request most recent head 0213dac. Consider uploading reports for the commit 0213dac to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   77.40%   77.38%   -0.03%     
==========================================
  Files          68       68              
  Lines        1974     1972       -2     
  Branches      550      550              
==========================================
- Hits         1528     1526       -2     
  Misses        405      405              
  Partials       41       41

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929955d...0213dac. Read the comment docs.

@regexowl regexowl force-pushed the wizard-v2-repositories branch 11 times, most recently from 093cf5d to fa114d0 Compare January 24, 2024 15:27
@regexowl
Copy link
Collaborator Author

I've tried to clean up the logic in Repositories.tsx a bit. There are a few things I'm not super happy with - those being not null assertions. I did my best to eliminate most of them alas some remained. If you have any suggestions on how to deal with them, please send them my way.

@regexowl regexowl changed the title [WIP] Wizard v2 repositories V2Wizard: Add Repositories step Jan 24, 2024
@regexowl regexowl force-pushed the wizard-v2-repositories branch 3 times, most recently from 4599c2a to 11043c9 Compare January 25, 2024 13:21
@regexowl regexowl force-pushed the wizard-v2-repositories branch 2 times, most recently from 9436664 to 456ec54 Compare January 25, 2024 14:07
@regexowl regexowl force-pushed the wizard-v2-repositories branch from 456ec54 to 4b36b80 Compare January 25, 2024 15:33
@lucasgarfield lucasgarfield force-pushed the wizard-v2-repositories branch from 4b36b80 to 19a5820 Compare January 26, 2024 08:17
@regexowl regexowl mentioned this pull request Jan 26, 2024
Closed
@lucasgarfield lucasgarfield force-pushed the wizard-v2-repositories branch from 19a5820 to e05abb0 Compare January 26, 2024 10:17
@regexowl
V2Wizard: Create a folder for Repositories step
a16f0fa 
This creates a new folder for the Repositories step and copies over all needed files:
- Repositories.tsx
- RepositoriesStatus.tsx
- RepositoryUnavailable.tsx
@regexowl regexowl force-pushed the wizard-v2-repositories branch from e05abb0 to ba24832 Compare January 26, 2024 10:28
@regexowl
V2Wizard: Add Repositories step to the Wizard
bd2caf0 
This adds Content as a step and Repositories as a substep to the Wizard.
@regexowl
V2Wizard: Add checkRepositoriesAvailability
545a275 
This adds checkRepositoriesAvailability.ts to a newly created `utilities` folder.
@regexowl
V2Wizard: Add components to the Repositories step skeleton
39e1d13 
This adds needed components to the Repositories step skeleton.
@regexowl
test: Add content test suite to V2Wizard
461b56d 
This adds disabled CreateImageWizard.content.test.tsx test suite to the V2Wizard.
@regexowl
test: Enable tests
0213dac 
This enables test for the Repositories step.
@regexowl regexowl force-pushed the wizard-v2-repositories branch from ba24832 to 0213dac Compare January 26, 2024 13:01
lucasgarfield
lucasgarfield approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@lucasgarfield lucasgarfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work! I wrote most of this original code and you've done a great job cleaning it up and adapting it to the new wizard... I'd still like to do a bit more refactoring on my old messy code but I think this is perfect for now and will let us keep moving and start working on the packages step! Thank you!

@lucasgarfield lucasgarfield merged commit c9e124b into osbuild:main Jan 26, 2024
2 of 3 checks passed
@regexowl regexowl deleted the wizard-v2-repositories branch January 26, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasgarfield lucasgarfield lucasgarfield approved these changes

Assignees
No one assigned
Labels
✅ ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regexowl @lucasgarfield