Resolve Controlled Component Error by Initializing with Empty Strings #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgold1234
requested review from
regexowl and
lucasgarfield
and removed request for
regexowl
mgold1234
force-pushed
the
empty_default_string
branch
3 times, most recently
from
7306100 to
25b1ec7
Compare
lucasgarfield
force-pushed
the
empty_default_string
branch
from
25b1ec7 to
d075949
Compare
regexowl
reviewed
Jan 26, 2024
src/Components/CreateImageWizardV2/steps/TargetEnvironment/Aws/index.tsx
Outdated
Show resolved
Hide resolved
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
regexowl
reviewed
Jan 26, 2024
src/Components/CreateImageWizardV2/steps/TargetEnvironment/Aws/AwsSourcesSelect.tsx
Outdated
Show resolved
Hide resolved
regexowl
reviewed
Jan 26, 2024
mgold1234
force-pushed
the
empty_default_string
branch
from
d075949 to
42b9e03
Compare
mgold1234
force-pushed
the
empty_default_string
branch
from
42b9e03 to
6316d75
Compare
|
/retest |
lavocatt
force-pushed
the
empty_default_string
branch
from
6316d75 to
fdc3772
Compare
lavocatt
requested changes
Jan 30, 2024
mgold1234
force-pushed
the
empty_default_string
branch
from
fdc3772 to
9011f43
Compare
mgold1234
force-pushed
the
empty_default_string
branch
from
9011f43 to
bd14f06
Compare
This commit fixes the "A component is changing an uncontrolled input to be controlled" error in React components by ensuring input values are consistently initialized as strings. Previously, values initialized as undefined led to inconsistencies in controlled component behavior. By initializing with empty strings or using value={someValue ?? ''}, we ensure that input components remain controlled throughout their lifecycle, complying with React's expectations for controlled components and enhancing overall component stability.
mgold1234
force-pushed
the
empty_default_string
branch
from
bd14f06 to
03a7d64
Compare
lavocatt
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
🚀 I think that this is exactly what @lucasgarfield had in mind in the slack thread the other day. Thanks for taking care of it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the "A component is changing an uncontrolled input to be controlled" error in React components by ensuring input values are consistently initialized as strings. Previously, values initialized as undefined led to inconsistencies in controlled component behavior. By initializing with empty strings or using value={someValue ?? ''}, we ensure that input components remain controlled throughout their lifecycle, complying with React's expectations for controlled components and enhancing overall component stability.