Wizard: Add kernel append input (HMS-5299) #2734
Conversation
|
/jira-epic HMS-5192 |
schutzbot
changed the title
regexowl
force-pushed
the
kernel-append-input
branch
from
6199c02 to
418f4aa
Compare
regexowl
force-pushed
the
kernel-append-input
branch
from
418f4aa to
265fa11
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2734 +/- ##
==========================================
+ Coverage 84.73% 84.77% +0.04%
==========================================
Files 186 186
Lines 20955 21120 +165
Branches 2033 2064 +31
==========================================
+ Hits 17756 17905 +149
- Misses 3177 3193 +16
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
|
I think there is a bug when creating an image with OScap -> required kernel added to the kernel step, |
| setErrorText(''); | ||
| } | ||
|
|
||
| if (kernelAppend.some((arg) => arg.name === value)) { |
There was a problem hiding this comment.
should I see this error in case I am adding the same kernel name?
now I dont see any error when adding the same name
There was a problem hiding this comment.
Hmm, yeah, we don't want duplicates. Will add a check for that!
There was a problem hiding this comment.
Tried to add a duplicate and got the correct error
What arguments did you try to add?
There was a problem hiding this comment.
I tried 'test' value
Screen.Recording.2025-01-14.at.14.03.32.mov
There was a problem hiding this comment.
ok, I got you, I think I check that I am adding 2 times the same value 'test',
if I tried to add same value that comes from the oscap profile the validation also doesnt work for me.
but, maybe we also want to check if user try to add same value ?
There was a problem hiding this comment.
Aah, gotcha, the validation was triggered only on keyDown 😳 will add a fix in a bit. Nice catch, thanks!
Ooh, I left the default parsing there, didn't I? Great catch! Will revert this to draft |
regexowl
force-pushed
the
kernel-append-input
branch
from
265fa11 to
74217f1
Compare
regexowl
force-pushed
the
kernel-append-input
branch
from
74217f1 to
b6c7247
Compare
regexowl
force-pushed
the
kernel-append-input
branch
3 times, most recently
from
728676c to
60653e7
Compare
|
The chipping input might be extractable from this one as well, moving to draft for the time being. #2747 will need to get merged first. |
This is in a preparation to expose kernel append customization. It will be easier to mutate kernel append if it's represented as an array of arguments, rather than currently used string.
This adds the kernel append input. New arguments can be added by pressing the "Add" button or hitting Enter after the argument. The kernel arguments linked to a selected OpenSCAP profile are rendered in a category marked as "Required by OpenSCAP" and are read only.
This removes kernel append from the list of information about the selected OpenSCAP step.
This adds basic tests for kernel append.
This updates the way the arguments are sorted by whether they're required by a selected OpenSCAP profile.
Only `keyDown` was validated, this makes sure that the plus button value is validated as well. Also the error text gets removed on change or clear.
regexowl
force-pushed
the
kernel-append-input
branch
from
60653e7 to
526afe0
Compare
This adds the kernel append input, removes kernel append from the OpenSCAP step and adds basic tests to cover the functionality.
TO DO:
JIRA: HMS-5299