manifest: change the serializeStart() to take a new Inputs arg
#1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of serializeStart() is a bit unwieldy and when adding librepo based sources this prompted for this proposed cleanup. The idea is to just pass a single "Inputs" struct to the serialization so that if we add field we don't need to change the signature all over the place. It also makes the calls easier to read (IMHO).
supakeen
approved these changes
Jan 14, 2025
achilleas-k
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of serializeStart() is a bit unwieldy and when adding librepo based sources this prompted for this proposed cleanup. The idea is to just pass a single "Inputs" struct to the serialization so that if we add field we don't need to change the signature all over the place. It also makes the calls easier to read (IMHO).
This contains only mechanical changes so the review shouldbe straightforward.
Unfortunately there will be conflicts with https://github.com/osbuild/images/pull/1095/files but after this is merged the other PR will be a lot smaller
We should merge this relatively soon as pretty much any PR will conflict with this one.
[edit: happy to discuss naming, I think
manifest.Inputsmakes sense in the context andserializeStart(inputs)too but open for ideas, some other possibilities: