Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some convenience things #36

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

schuellerf
Copy link
Collaborator

This PR does not contain functional changes but mainly convenience and a minor fix to requirements.txt

Avoids to crash in case of errors, but rather
report them and quit.
Github API library supports handling of environment
variables, so we'll support it for easier local setup.
Those packets are required but were not listed.
Copy link
Collaborator

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ochosi ochosi merged commit cef13f1 into osbuild:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants