fix(timepicker): typo OdsTimezonesPreset #675
Open
+49
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Esteves <[email protected]>
aesteves60
force-pushed
the
fix-timezones-preset
branch
from
52052c4 to
4204bcb
Compare
dpellier
reviewed
Jan 21, 2025
| import React, { HTMLAttributes, RefAttributes } from 'react'; | ||
|
|
||
| const TestTimepicker: React.FC< | ||
| Partial< |
There was a problem hiding this comment.
Test when defining custom props and using previous OdsTimezonePreset type on one.
dpellier
reviewed
Jan 21, 2025
| @@ -2,12 +2,16 @@ enum ODS_TIMEZONES_PRESET { | |||
| all = 'all' | |||
| } | |||
|
|
|||
| /** @deprecated use `OdsTimezonesPreset` instead */ | |||
There was a problem hiding this comment.
if we can't get it on the doc generation, we should at least manually add a warn message on the Technical page of the component
Signed-off-by: Alexandre Esteves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.