fix: deny netblocks for nc, mtr, ping, alive plugins

ovh · Dec 20, 2024 · 9a4a402 · 9a4a402
1 parent 1859d6a
commit 9a4a402
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/bin/plugin/open/alive b/bin/plugin/open/alive
@@ -51,6 +51,11 @@ if (not $host) {
     osh_exit 'ERR_MISSING_PARAMETER', "Missing required host parameter";
 }
 
+if ($host =~ m{/}) {
+    help();
+    osh_exit 'ERR_INVALID_PARAMETER', "Please use a single IP, not a netblock";
+}
+
 osh_info "Waiting for $host to be alive...";
 my $startedat = Time::HiRes::gettimeofday();
 my $firstLoop = 1;

diff --git a/bin/plugin/open/mtr b/bin/plugin/open/mtr
@@ -42,6 +42,11 @@ if (not $host) {
     osh_exit 'ERR_MISSING_PARAMETER', "Missing required host parameter";
 }
 
+if ($host =~ m{/}) {
+    help();
+    osh_exit 'ERR_INVALID_PARAMETER', "Please use a single IP, not a netblock";
+}
+
 my @command = qw{ mtr --show-ips --aslookup -n };
 push @command, ($report ? '--report' : '--curses');
 push @command, $host;

diff --git a/bin/plugin/open/nc b/bin/plugin/open/nc
@@ -59,6 +59,11 @@ if (!$fnret) {
     osh_exit $fnret;
 }
 
+if ($host =~ m{/}) {
+    help();
+    osh_exit 'ERR_INVALID_PARAMETER', "Please use a single IP, not a netblock";
+}
+
 osh_info "Checking whether TCP port $port of $host is reachable...";
 
 my $Sock = IO::Socket->new(

diff --git a/bin/plugin/open/ping b/bin/plugin/open/ping
@@ -53,6 +53,11 @@ if (not $host) {
     osh_exit 'ERR_MISSING_PARAMETER', "Missing required host parameter";
 }
 
+if ($host =~ m{/}) {
+    help();
+    osh_exit 'ERR_INVALID_PARAMETER', "Please use a single IP, not a netblock";
+}
+
 my @command = qw{ ping };
 if ($count and $count > 0) {
     push @command, ('-c', $count);