Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade go pg #374

Merged
merged 24 commits into from
Aug 26, 2024
Merged

Downgrade go pg #374

merged 24 commits into from
Aug 26, 2024

Conversation

srieckhof
Copy link
Contributor

@srieckhof srieckhof commented Aug 23, 2024 •
edited
Loading

Detailed changes description:

  1. revert all changes that are due to changes in go-pg from this previous commit a4d7cc1#diff-96a9c4960a91cf3bb9fd115d50c8e7ef0f98de9cb856e9d4c09465d958a4cf0c
  2. golang-ci.yml
  • update go version from 1.21.3 to 1.21.12 because this fixes vulnarability issues
  • install docker-compose before running the integration tests
  • actually run the integration and not (again) the unit tests as was the case with "make ci"
  • add "make lint" step to CI
  1. fix issues resulting from "make lint"
  2. fix integration test in cache.go

closes #373

stefan.rieckhof added 20 commits August 23, 2024 07:09
downgrade go-pg from v10 to v6.14.5
3758b3d
update modules.txt
21fe0b2
fix linting
fd03501
update golang CI version from 1.21.3 to 1.21.12 to fix some vulnarabi…
75e4545 
…lities
update golang.org/x/net from v0.20.0 to 0.23.0 to fix a vulnarability
d257391
add installation of docker-compose to golang-ci.yml
6ca68f8
go back to docker/login-action v1 in golang-ci.yml
ecdba7e
actually run the integration tests
57afc4c
DEBUG skip the livetest
6f82328
call integration in the ci Makefile command
4898219
revert: call integration in the ci Makefile command
7977e66
increase wait time in integration test
7c4e94d
increase wait time in integration test
ca950ea
DEBUG add assertions
566b3be
DEBUG adjust durations in test
a23c40d
DEBUG remove assertion for no error
864f9e8
add coverage related flags to make test
97ab8d9
don't skip one specific integration test anymore
3f72b08
go back to v3 of docker/login-action
c5c7aa7
add linting step to CI
4d2da8c
arnold-iakab
arnold-iakab reviewed Aug 26, 2024
View reviewed changes
backend/postgres/postgres.go Outdated Show resolved Hide resolved
http/jsonapi/response_test.go Outdated Show resolved Hide resolved
@srieckhof srieckhof requested a review from arnold-iakab August 26, 2024 13:29
arnold-iakab
arnold-iakab approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@arnold-iakab arnold-iakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpwenzel jpwenzel merged commit b1eb668 into master Aug 26, 2024
6 checks passed
@jpwenzel jpwenzel deleted the downgrade_go-pg branch August 26, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnold-iakab arnold-iakab arnold-iakab approved these changes

@jpwenzel jpwenzel jpwenzel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downgrade go-pg from v10 to v6.14.5
3 participants
@srieckhof @jpwenzel @arnold-iakab