Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React's useSyncExternalStore #333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dchenk
Copy link

@dchenk dchenk commented Dec 30, 2024

React added support for useSyncExternalStore as a stable feature in version 18. Our peerDependencies requires at least version 18 of React, so all users will have useSyncExternalStore available without the need for a shim.

Apart from being a cleanup and reducing the number of dependencies, this fixes a problem I encountered when trying to bundle React to be a standalone module.

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview Dec 30, 2024 9:51pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant