Skip to content

Commit

Permalink
bdr cran fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
levisc8 committed Nov 16, 2021
1 parent c23c490 commit 37ad6af
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
8 changes: 4 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ Depends:
Imports:
ggplot2,
magrittr,
maps,
mvtnorm,
purrr,
rlang (>= 0.3.0),
Expand All @@ -62,10 +61,11 @@ BugReports: https://github.com/padrinoDB/Rpadrino/issues
URL: https://github.com/padrinoDB/Rpadrino, https://padrinoDB.github.io/Rpadrino/
RoxygenNote: 7.1.2
Suggests:
testthat,
knitr,
covr,
roxygen2
knitr,
maps,
roxygen2,
testthat
VignetteBuilder: knitr
Config/testthat/parallel: true
Config/testthat/edition: 3
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
This is a resubmission of the first submission of Rpadrino. We have added "'"s around software names in the DESCRIPTION, updated the documentation to include \value tags for all exported functions, and ensured our tests now reset user graphical options in the testing suite.
This is a resubmission of the first submission of Rpadrino. We have updated our tests to run on Solaris in the absence of Pandoc, and a note about imported packages on Fedora.

Additional information on this submission:

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-ipmr_generics.R
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ test_that("convergence diagnostics", {

y <- pdb_make_ipm(x)

old_par <- par()
old_par <- par(no.readonly = TRUE)

par(mfrow = c(2,2))

Expand Down
4 changes: 4 additions & 0 deletions tests/testthat/test-pdb_report.R
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ data(pdb)

test_that("pdb_report generates correct output", {

skip_if_not(rmarkdown::pandoc_available(version = "1.12.3"))

out_temp <- tempdir()
dir.create(out_temp, FALSE)

Expand Down Expand Up @@ -32,6 +34,8 @@ test_that("pdb_report generates correct output", {

test_that("full filenames work too", {

skip_if_not(rmarkdown::pandoc_available(version = "1.12.3"))

out_temp <- tempdir()
dir.create(out_temp, FALSE)

Expand Down

0 comments on commit 37ad6af

Please sign in to comment.