fix: js return undefined and block loading when it should not #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateus-picoloto
approved these changes
Jan 9, 2024
mauriciohaygert
approved these changes
Jan 9, 2024
mauriciohaygert
approved these changes
Jan 9, 2024
RafaMelazzo
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Certifique-se de criar o PR para a branch develop.
Qual o tipo de PR é esse? (marque todos os aplicáveis)
Descrição
Quando não possui um método de pagamento por ser compra com valor zero, a função isPagarmePayment retornava undefined, gerando outros erros futuros.
Também foi adicionado uma validação para caso o método de pagamento não seja pagarme, não tentar adicionar o valor das parcelas.
Cenários testados