-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-1279][DEV-1996][DEV-1997] Generate sitemap xml of the site #1277
base: main
Are you sure you want to change the base?
Conversation
- Implemented a new sitemap.ts file to generate a sitemap for the Next.js website. - Integrated dynamic paths for guides, case histories, products, and API routes. - Defined base, auth, profile, and guide routes with appropriate metadata including last modified date, change frequency, and priority. - Enhanced SEO by providing structured URLs for various site sections.
🦋 Changeset detectedLatest commit: b606bc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Add NEXT_PUBLIC_BASE_URL to .env for referncing sitemap on robots |
})); | ||
|
||
return [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many pages are missing from the sitemap:
- solution list page
- the solution preview pages
- the solution details pages
- the webinar list page
- the webinars pages
- the guide pages
- the tutorial pages (
tutorials/come-utilizzare-correttamente-servizi-e-messaggi-in-app-io
) - the guide and tutorial subpages
- etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something wrong with:
- links to tutorial pages
<loc>https://dev.developer.pagopa.it/app-io/tutorials/[object Object]</loc>
- links to guide pages, which link to the main page of each guide several times
- links to guide pages, where the link is malformed (the prefix is repeated twice) as you can see in this example
/app-io/guides//app-io/guides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should resolve this comment
...webinarRoutes, | ||
...solutionRoutes, | ||
...solutionsDetailRoutes, | ||
...sectionRoutes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terms-of-service
is missing and i'm not sure about publishing auth and profile's routes
Co-authored-by: Marco Ponchia <[email protected]>
…structures for tutorials and guides. This enhances the sitemap's accuracy and SEO by providing cleaner, more structured URLs.
Branch is not up to date with base branch@tommaso1 it seems this Pull Request is not updated with base branch. |
Co-authored-by: Marco Ponchia <[email protected]>
Co-authored-by: Marco Ponchia <[email protected]>
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-1279 |
Bundle not found for branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tos
List of Changes
Add sitemap.xml to website
Motivation and Context
Search engines will read this file to crawl the Developer Portal site more efficiently.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: